> -----Original Message----- > From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf > Of Michel Dänzer > Sent: Tuesday, November 01, 2016 11:51 PM > To: Alex Deucher > Cc: Zhang, Jerry; amd-gfx at lists.freedesktop.org > Subject: Re: [1/4] amdgpu: add the function to get the marketing name (v2) > > On 01/11/16 06:34 PM, Michel Dänzer wrote: > > On 13/09/16 12:14 AM, Alex Deucher wrote: > >> From: Junwei Zhang <Jerry.Zhang at amd.com> > >> > >> This function is used to look up the marking name > >> for a specific board. > >> > >> v2: agd: Squash in subsequent updates to the table. > > > > As is, this breaks make check: > > > > > >> +struct amdgpu_asic_id_table_t { > > > > Make this static, so the amdgpu_asic_id_table_t symbol doesn't get > > exported from libdrm_amdgpu. > > > > BTW, is there any particular reason for putting this table in a separate > > header file? > > > > > >> @@ -303,3 +304,17 @@ int > amdgpu_device_deinitialize(amdgpu_device_handle dev) > >> amdgpu_device_reference(&dev, NULL); > >> return 0; > >> } > >> + > >> +const char *amdgpu_get_marketing_name(amdgpu_device_handle > dev) > > > > amdgpu_get_marketing_name needs to be added to amdgpu-symbols- > check. > > > > > >> + if ((t->did == dev->info.asic_id) && > >> + (t->rid == dev->info.pci_rev_id)) > > > > Wrong indentation of the second line. > > > > > > With these issues fixed, > > > > Reviewed-by: Michel Dänzer <michel.daenzer at amd.com> > > > > Would be nice to land this in master soon, as we're going to use it in > > xf86-video-amdgpu: https://patchwork.freedesktop.org/patch/119501/ > > Junwei, if it's okay with you, I can amend the patch and push it to master. You might double check the internal git tree and pick up any additional marketing names that were added since I pulled those patches. Alex > > > -- > Earthling Michel Dänzer | http://www.amd.com > Libre software enthusiast | Mesa and X developer > _______________________________________________ > amd-gfx mailing list > amd-gfx at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
