On Tue, Aug 30, 2016 at 08:30:57PM +0800, Christian König wrote: > For patch #4: > > drm/amdgpu: remove useless functions of si dpm > Maybe call that "remove unused function forward define". > > And in general patches should at least have a commit message and not > just subject. A simple one liner like "The functions don't exists any > more." should be sufficient in this case. > I see, you're right. "unused function" is better, I will update it at V2. > Patch #10: > > Well we probably shouldn't call those functions rv770_* any more. > Yep, I would like to remove that function. Use "adev->mc.vram_type == AMDGPU_VRAM_TYPE_GDDR5" instead of mem_gddr5 flag. > Apart from that the patches look good to me, but since I'm clearly not > the DPM expert they are Acked-by: Christian König > <christian.koenig at amd.com>. > Thank you, Rui
