Yes, I think it should be removed. Alex From: amd-gfx [mailto:amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx] On Behalf Of StDenis, Tom Sent: Friday, August 26, 2016 9:07 AM To: amd-gfx list Subject: Errant return in Carrizo SMU code In the function static int cz_check_fw_load_finish(struct pp_smumgr *smumgr, uint32_t firmware); On line 198 of powerplay/smumgr/cz_smumgr.c there is an unconditional return in the middle of the function. Is that an error or is the code after it truly dead code? Tom -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20160826/4f89fd75/attachment.html>