Hi Emil, Each point of the patch set is not broken. Patches are arranged like this to show how I do it: 1. create a pageflip.c to host common page flip code 2. copy amdgpu DDX DRI2 page flip code to modesetting dri2.c 3. merge common DRI2 and present page flip code to pageflip.c Patch 4 is not a fix for broken code, just a commit from amdgpu DDX to prevent present and DRI2 from flipping at the same time. Regards, Qiang ________________________________________ From: Emil Velikov <emil.l.velikov@xxxxxxxxx> Sent: Thursday, August 18, 2016 7:03:12 PM To: Yu, Qiang Cc: ML xorg-devel; amd-gfx at lists.freedesktop.org Subject: Re: [PATCH xserver 0/6] modesetting: add DRI2 page flip support Hi Qiang, On 17 August 2016 at 11:29, Qiang Yu <Qiang.Yu at amd.com> wrote: > Hi guys, > > This patch set is for adding DRI2 page flip support to modesetting > driver. I mainly take reference of amdgpu DDX and reuse present > page flip code in the modesetting driver. > > Regards, > Qiang > > Qiang Yu (6): > modesetting: make ms_do_pageflip generic for share with DRI2 > modesetting: move ms_do_pageflip to pageflip.c > modesetting: add DRI2 page flip support > modesetting: exclude DRI2 and Present page flip > modesetting: merge common page flip code for present and dri2 > modesetting: remove redundent pixmap destroy > The work itself is quite interesting thanks for that ! Is it me or the newly added code (with patch 3) seems intermittently broken (fixed with patch 4), and then removed with a later patch (5) ? Should one factor the common pageflip code first, then add the distinction between dri2 and present flips, then finally add the dri2 implementation ? Regards, Emil
