> Has a [1] array at the tail which is then kzalloc'ed with N-1 entries. > Shouldn't that just be a [0] with N entries allocated for clarity? Actually the starting address of a dynamic array should be manually calculated instead of using [1] or [0]. We had tons of problems with that because some gcc versions get this wrong and the atombios code used this as well. Alex how did we resolved such issues? Regards, Christian. Am 18.08.2016 um 16:26 schrieb StDenis, Tom: > > Tidying up cz_hwmgr.c I noted a couple of things but first is > > > static bool cz_dpm_check_smu_features(struct pp_hwmgr *hwmgr, > unsigned long check_feature); > > Which will return "true" if the smu call fails *or* the feature is set. > > The structure > > struct phm_clock_voltage_dependency_table; > > Has a [1] array at the tail which is then kzalloc'ed with N-1 entries. > Shouldn't that just be a [0] with N entries allocated for clarity? > > Tom > > > > _______________________________________________ > amd-gfx mailing list > amd-gfx at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20160818/857f0f5b/attachment.html>
