[PATCH] Standardizing the info message for unimplemented functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 8 Aug 2016 at 01:22 Huang Rui <ray.huang at amd.com> wrote:

> On Sun, Aug 07, 2016 at 05:17:41PM -0400, Alexandre Demers wrote:
> > Signed-off-by: Alexandre Demers <alexandre.f.demers at gmail.com>
> >
> > ---
> >  drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 22 +++++++++++-----------
> >  1 file changed, 11 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
> b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
> > index 07e0475..9e327be 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
> > @@ -106,14 +106,14 @@ static const uint32_t hpd_int_control_offsets[6] =
> {
> >  static u32 dce_v6_0_audio_endpt_rreg(struct amdgpu_device *adev,
> >                                    u32 block_offset, u32 reg)
> >  {
> > -     DRM_INFO("xxxx: dce_v6_0_audio_endpt_rreg ----no impl!!!!\n");
> > +     DRM_INFO("xxxx: dce_v6_0_audio_endpt_rreg --- not implemented!\n");
> >       return 0;
>
> We can make the code more simple like below:
>
> DRM_INFO("xxxx: %s --- not implemented!\n", __func__);
>
> Thanks,
> Rui
>

I like your suggestion. I'll send a v2 later, I also saw that I had missed
one or two of them.

That being said, I have other work that I'll send in the next few days for
review.

Cheers,
Alexandre Demers
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20160808/9d00fa66/attachment.html>


[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux