OK, remember that.
Thanks,
Qiang
________________________________________
From: Michel Dänzer <michel@xxxxxxxxxxx>
Sent: Wednesday, July 20, 2016 3:18:56 PM
To: Yu, Qiang
Cc: amd-gfx at lists.freedesktop.org
Subject: Re: [PATCH][xf86-video-amdgpu] Fix amdgpu_mode_hotplug crash on multi GPU platform.
On 13.07.2016 20:25, Qiang Yu wrote:
> On multi GPU platform, some screen is created by other GPU DDX.
>
> Change-Id: Ifa69fe1ec94faf4d6011707c146a0f9d535f95c4
> Signed-off-by: Qiang Yu <Qiang.Yu at amd.com>
> ---
> src/drmmode_display.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/drmmode_display.c b/src/drmmode_display.c
> index 5bddfd0..0e513cf 100644
> --- a/src/drmmode_display.c
> +++ b/src/drmmode_display.c
> @@ -2344,7 +2344,8 @@ restart_destroy:
> xf86CrtcConfigPtr loop_config =
> XF86_CRTC_CONFIG_PTR(loop_scrn);
>
> - if (AMDGPUEntPriv(loop_scrn) != pAMDGPUEnt)
> + if (strcmp(loop_scrn->driverName, scrn->driverName) ||
> + AMDGPUEntPriv(loop_scrn) != pAMDGPUEnt)
> continue;
>
> for (j = 0; !found && j < loop_config->num_output; j++) {
>
I wonder if there isn't a better way for this than comparing the driver
name, but I guess it'll do for now.
Reviewed and pushed, thanks!
P.S. The proper way to indicate the repository a patch applies to is
within the [PATCH] prefix itself, i.e. in this case [PATCH
xf86-video-amdgpu]. After you run the command
git config format.subjectprefix "PATCH $(basename $PWD)"
in a Git repository, it should be included automatically by git
format-patch.
Also, please remove Gerrit Change-Id: lines from the commit log when
submitting patches upstream.
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
