Please use the bool type and true/false for use_bank. Apart from that the patch looks like the right approach to me. BTW: On public mailing lists we usually use inline patches for reviews. Regards, Christian. Am 27.06.2016 um 18:32 schrieb StDenis, Tom: > > This adds the ability to select SH/SE banks in the debugfs entry. > > > In concert with the other patch I sent out this morning (the config > debugfs entry) the debug tool can now select banks and sanity check > user input. > > > Tom > > > > _______________________________________________ > amd-gfx mailing list > amd-gfx at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20160628/442110c1/attachment.html>