On 2016å¹´06æ??24æ?¥ 11:14, Deucher, Alexander wrote: >> -----Original Message----- >> From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf >> Of zhoucm1 >> Sent: Thursday, June 23, 2016 10:47 PM >> To: amd-gfx at lists.freedesktop.org >> Subject: Re: [PATCH 0/6] misc gfx cleanups >> >> >> >> On 2016å¹´06æ??22æ?¥ 00:28, Alex Deucher wrote: >>> Misc gfx7/gfx8 cleanups. >> patches all are Reviewed-by: Chunming Zhou <david1.zhou at amd.com> >> >> btw: are you going to add wait_for_mc_idle to GMC ip block specific funcs? > I added a the new amdgpu_wait_for_idle() function in the other patch set, so just call: > amdgpu_wait_for_idle(adev, AMD_IP_BLOCK_TYPE_GMC); > and it will call the ip wait for idle callback for the gmc ip block which is what the old asic callback used to map to. OK, I see. When I checked them just now, I found gmc_v8_0_mc_wait_for_idle and gmc_v8_0_wait_for_idle are same, then we should remove one of them. Regards, David Zhou > > Alex > >> Regards, >> David Zhou >>> Alex Deucher (6): >>> drm/amdgpu/gmc: make some functions static >>> drm/amdgpu: drop wait_for_mc_idle asic callback >>> drm/amdgpu: move get_gpu_clock_counter into the gfx struct >>> drm/amdgpu: move select_se_sh into the gfx struct >>> drm/amdgpu/gfx7: switch to using the existing rlc callbacks >>> drm/amdgpu/gfx7: make gfx_v7_0_rlc_stop static >>> >>> drivers/gpu/drm/amd/amdgpu/amdgpu.h | 15 +++++++++------ >>> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 4 ++-- >>> drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +- >>> drivers/gpu/drm/amd/amdgpu/ci_dpm.c | 6 +++--- >>> drivers/gpu/drm/amd/amdgpu/cik.c | 7 ++----- >>> drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 23 >> ++++++++++++++++++----- >>> drivers/gpu/drm/amd/amdgpu/gfx_v7_0.h | 7 ------- >>> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 11 +++++++++-- >>> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.h | 1 - >>> drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 16 ++++++++-------- >>> drivers/gpu/drm/amd/amdgpu/gmc_v7_0.h | 7 ------- >>> drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 16 ++++++++-------- >>> drivers/gpu/drm/amd/amdgpu/gmc_v8_0.h | 7 ------- >>> drivers/gpu/drm/amd/amdgpu/kv_dpm.c | 6 +++--- >>> drivers/gpu/drm/amd/amdgpu/vi.c | 7 ++----- >>> 15 files changed, 65 insertions(+), 70 deletions(-) >>> >> _______________________________________________ >> amd-gfx mailing list >> amd-gfx at lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
