On Wed, 2019-11-06 at 13:08 +0100, Sebastian Reichel wrote: > Hi, > > On Wed, Nov 06, 2019 at 10:51:06AM +0200, Matti Vaittinen wrote: > > The patch series adds definitions for GPIO line directions. > > > > For occasional GPIO contributor like me it is always a pain to > > remember > > whether 1 or 0 was used for GPIO direction INPUT/OUTPUT. > > Maybe also update the GPIO drivers in pinctrl? > > $ git grep -l gpio_get_direction drivers/pinctrl > drivers/pinctrl/bcm/pinctrl-bcm2835.c > drivers/pinctrl/bcm/pinctrl-iproc-gpio.c > drivers/pinctrl/intel/pinctrl-baytrail.c > drivers/pinctrl/intel/pinctrl-cherryview.c > drivers/pinctrl/intel/pinctrl-intel.c > drivers/pinctrl/mediatek/pinctrl-mtk-common.c > drivers/pinctrl/mediatek/pinctrl-paris.c > drivers/pinctrl/mvebu/pinctrl-armada-37xx.c > drivers/pinctrl/pinctrl-amd.c > drivers/pinctrl/pinctrl-at91.c > drivers/pinctrl/pinctrl-axp209.c > drivers/pinctrl/pinctrl-ingenic.c > drivers/pinctrl/pinctrl-ocelot.c > drivers/pinctrl/pinctrl-oxnas.c > drivers/pinctrl/pinctrl-pic32.c > drivers/pinctrl/pinctrl-pistachio.c > drivers/pinctrl/pinctrl-rk805.c > drivers/pinctrl/pinctrl-rockchip.c > drivers/pinctrl/pinctrl-rza1.c > drivers/pinctrl/pinctrl-st.c > drivers/pinctrl/pinctrl-stmfx.c > drivers/pinctrl/pinctrl-sx150x.c > drivers/pinctrl/qcom/pinctrl-msm.c > drivers/pinctrl/stm32/pinctrl-stm32.c > drivers/pinctrl/vt8500/pinctrl-wmt.c Ouch. I didn't check from pinctrl but I see those should be converted as well. I'm a bit short on time right now so if anyone else is interested I won't mind :) Luckily the value for IN and OUT is not changed - only the defines were added - so all of the drivers do not need to be done at once. If no one else will take the pinctrl part then I can probably do pinctrl patches for v5.6 cycle. Br, Matti Vaittinen _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
