Hi, On Mon, 4 Nov 2019, Yong Zhi wrote: > Use devm_gpio_request() to automatic unroll when fails and avoid > resource leaks at error paths. this is a bugfix still, so maybe reword as: Fix resource leaks on error paths by using devm_gpio_request(). > Signed-off-by: Yong Zhi <yong.zhi@xxxxxxxxx> > --- > v2 change: > - use devm_gpio_request to avoid the goto statement based on review comments. All in all, looks good, move to devm_ is even better! Br, Kai _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel