Hi, Kai, Daniel and Mark, > -----Original Message----- > From: Mark Brown <broonie@xxxxxxxxxx> > Sent: Monday, November 4, 2019 7:18 AM > To: Daniel Baluta <daniel.baluta@xxxxxxx> > Cc: pierre-louis.bossart@xxxxxxxxxxxxxxx; Zhi, Yong <yong.zhi@xxxxxxxxx>; > Nujella, Sathyanarayana <sathyanarayana.nujella@xxxxxxxxx>; > ryans.lee@xxxxxxxxxxxxxxxxxxx; alsa-devel@xxxxxxxxxxxxxxxx > Subject: Re: [PATCH] ASoC: max98373: Fix calls to free_gpio() > > On Mon, Nov 04, 2019 at 01:03:38PM +0000, Daniel Baluta wrote: > > On Fri, 2019-11-01 at 12:08 -0500, Yong Zhi wrote: > > > Don't Call free_gpio() when request_gpio() fails, call it at error > > > paths to avoid resource leak. > > > Uosing devm_gpio_request will make the change cleaner. > > What do you think? > > Yes, that's even better. Acked, will use devm version which is more elegant, thanks for the code review. -Yong _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
