Hi, On Fri, 1 Nov 2019, Yong Zhi wrote: > Don't Call free_gpio() when request_gpio() fails, call it > at error paths to avoid resource leak. patch looks good to me: Reviewed-by: Kai Vehmanen <kai.vehmanen@xxxxxxxxxxxxxxx> PS This is good as a clear bugfix. For future, use of devm_gpiod_get_*() and friends is recommended. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel