On 10/25/19 11:14 AM, Lu, Brent wrote:
Can you clarify if the rt5514 needs the MCLK while it's doing the hotword
detection?
No, running the detection does not raise the bias level so the set_bias_level
will not be called. The mclk is only turned on then off in mixer control's handler
(rt5514_dsp_voice_wake_up_put) when enabling the hotword detection.
My point is really that this patch uses a card-level BIAS indication, and I'd like
to make sure this does not interfere with the audio DSP being in D3 state.
The function checks the name of dapm so it would only react when rt5514's
bias level is changing. And also the idle_bias_off of the codec driver is true so
it's target_bias_level should not be overwritten in the dapm_power_widgets()
function. The behavior should be similar to the previous patch which is using
supply widget.
Ah yes, I did miss this test:
+ if (!component || strcmp(component->name, RT5514_DEV_NAME))
+ return 0;
Looks good then, thanks for the explanations.
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
