On Wed, Oct 23, 2019 at 2:31 PM Mao Wenan <maowenan@xxxxxxxxxx> wrote: > > If SND_SOC_MT8183_MT6358_TS3A227E_MAX98357A=y, > below errors can be seen: > sound/soc/codecs/cros_ec_codec.o: In function `send_ec_host_command': > cros_ec_codec.c:(.text+0x534): undefined reference to `cros_ec_cmd_xfer_status' > cros_ec_codec.c:(.text+0x101c): undefined reference to `cros_ec_get_host_event' > > This is because it will select SND_SOC_CROS_EC_CODEC > after commit 2cc3cd5fdc8b ("ASoC: mediatek: mt8183: support WoV"), > but SND_SOC_CROS_EC_CODEC depends on CROS_EC. > > Fixes: 2cc3cd5fdc8b ("ASoC: mediatek: mt8183: support WoV") > Signed-off-by: Mao Wenan <maowenan@xxxxxxxxxx> > --- > sound/soc/mediatek/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/mediatek/Kconfig b/sound/soc/mediatek/Kconfig > index 8b29f39..a656d20 100644 > --- a/sound/soc/mediatek/Kconfig > +++ b/sound/soc/mediatek/Kconfig > @@ -125,7 +125,7 @@ config SND_SOC_MT8183_MT6358_TS3A227E_MAX98357A > select SND_SOC_MAX98357A > select SND_SOC_BT_SCO > select SND_SOC_TS3A227E > - select SND_SOC_CROS_EC_CODEC > + select SND_SOC_CROS_EC_CODEC if CROS_EC > help > This adds ASoC driver for Mediatek MT8183 boards > with the MT6358 TS3A227E MAX98357A audio codec. > -- > 2.7.4 > Just realized your patch seems not showing in the list (https://mailman.alsa-project.org/pipermail/alsa-devel/2019-October/thread.html). I have no idea why. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel