Hi Morimoto-san, On Fri, Feb 22, 2019 at 09:23:23AM +0100, twischer@xxxxxxxxxxxxxx wrote: > From: Jiada Wang <jiada_wang@xxxxxxxxxx> > > Currently each SSI unit 's busif dma address is calculated by > following calculation formulation: > 0xec540000 + 0x1000 * id + busif / 4 * 0xA000 + busif % 4 * 0x400 > > But according to user manual 41.1.4 Register Configuration > ssi9 4/5/6/7 busif data register address > (SSI9_4_BUSIF/SSI9_5_BUSIF/SSI9_6_BUSIF/SSI9_7_BUSIF) > are out of this rule. > > This patch updates the calculation formulation to correct > ssi9 4/5/6/7 busif data register address > > Fixes: commit 5e45a6fab3b9 ("ASoc: rsnd: dma: Calculate dma address with consider of BUSIF") > Signed-off-by: Jiada Wang <jiada_wang@xxxxxxxxxx> > Signed-off-by: Timo Wischer <twischer@xxxxxxxxxxxxxx> > --- > sound/soc/sh/rcar/dma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/sh/rcar/dma.c b/sound/soc/sh/rcar/dma.c > index 0324a5c..28f65eb 100644 > --- a/sound/soc/sh/rcar/dma.c > +++ b/sound/soc/sh/rcar/dma.c > @@ -508,10 +508,10 @@ static struct rsnd_mod_ops rsnd_dmapp_ops = { > #define RDMA_SSI_I_N(addr, i) (addr ##_reg - 0x00300000 + (0x40 * i) + 0x8) > #define RDMA_SSI_O_N(addr, i) (addr ##_reg - 0x00300000 + (0x40 * i) + 0xc) > > -#define RDMA_SSIU_I_N(addr, i, j) (addr ##_reg - 0x00441000 + (0x1000 * (i)) + (((j) / 4) * 0xA000) + (((j) % 4) * 0x400)) > +#define RDMA_SSIU_I_N(addr, i, j) (addr ##_reg - 0x00441000 + (0x1000 * (i)) + (((j) / 4) * 0xA000) + (((j) % 4) * 0x400) - (0x4000 * ((i) / 9) * ((j) / 4))) > #define RDMA_SSIU_O_N(addr, i, j) RDMA_SSIU_I_N(addr, i, j) > > -#define RDMA_SSIU_I_P(addr, i, j) (addr ##_reg - 0x00141000 + (0x1000 * (i)) + (((j) / 4) * 0xA000) + (((j) % 4) * 0x400)) > +#define RDMA_SSIU_I_P(addr, i, j) (addr ##_reg - 0x00141000 + (0x1000 * (i)) + (((j) / 4) * 0xA000) + (((j) % 4) * 0x400) - (0x4000 * ((i) / 9) * ((j) / 4))) > #define RDMA_SSIU_O_P(addr, i, j) RDMA_SSIU_I_P(addr, i, j) > > #define RDMA_SRC_I_N(addr, i) (addr ##_reg - 0x00500000 + (0x400 * i)) Reviewed-by: Eugeniu Rosca <erosca@xxxxxxxxxxxxxx> This patch lives in our tree for a while without any issues. It still applies cleanly to v5.4-rc4-18-g3b7c59a1950c. Any chance to see it in vanilla? -- Best Regards, Eugeniu _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel