On 11/10/19 3:03 AM, vishnu wrote: > Hi, > Please find my inline comments. > > Thanks, > Vishnu > > On 01/10/19 10:59 PM, Mark Brown wrote: >> On Tue, Oct 01, 2019 at 05:23:43PM +0000, Deucher, Alexander wrote: >> >>>> ACP-PCI controller driver does not depends msi interrupts. >>>> So removed msi related pci functions which have no use and does not >>>> impact >>>> on existing functionality. >> >>> In general, however, aren't MSIs preferred to legacy interrupts? >> >> As I understand it. Or at the very least I'm not aware of any situation >> where they're harmful. It'd be good to have a clear explanation of why >> we're removing the support. > > Actually our device is audio device and it does not depends on MSI`s. > So we thought to remove it as it has no purpose or meaning to have > this code in our audio based ACP-PCI driver. > >>> Doesn't the driver have to opt into MSI support? As such, won't >>> removing this code effectively disable MSI support? >> >> Yes. > > Hi Mark, Any updates on this patch. Regards, Vishnu _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
