On Wed, Oct 16, 2019 at 3:28 AM Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> wrote: > > > Hi Pierre-Louis > > > >>>> Without <types.h> we will get these error > > >>>> > > >>>> linux/include/sound/sof/header.h:125:2: error: unknown type name ‘uint32_t’uint32_t size; > > >>>> linux/include/sound/sof/header.h:136:2: error: unknown type name ‘uint32_t’uint32_t size; > > >>>> linux/include/sound/sof/header.h:137:2: error: unknown type name ‘uint32_t’uint32_t cmd; > > >>>> ... > > >>>> linux/include/sound/sof/dai-imx.h:18:2: error: unknown type name ‘uint16_t’uint16_t reserved1; > > >>>> linux/include/sound/sof/dai-imx.h:30:2: error: unknown type name ‘uint16_t’uint16_t tdm_slot_width; > > >>>> linux/include/sound/sof/dai-imx.h:31:2: error: unknown type name ‘uint16_t’uint16_t reserved2; > (snip) > > this is a file shared with the firmware, we shouldn't have to add > > linux specific stuff in there. > > > > Also I don't know how you get those errors, we've been using this file > > for some time, can you clarify how this error happens? > > I had got this error by using "make allyesconfig" and compile for x86. Sorry, I've earlier sent an empty message. Ok, then IStephen's patch fixes the issue and we should not touch include/sound/sof/header.h That means Mark needs to drop Morimoto-san's patch. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
