On Mon, Sep 30, 2019 at 05:58:18PM +0200, Michał Mirosław wrote: > On Sat, Sep 28, 2019 at 04:16:41PM +0800, YueHaibing wrote: > > when do randbuilding, I got this error: > > > > sound/soc/atmel/atmel_ssc_dai.o: In function `atmel_ssc_set_audio': > > (.text+0x12f6): undefined reference to `atmel_pcm_pdc_platform_register' > > > > This is because SND_ATMEL_SOC_SSC_DMA=y, SND_ATMEL_SOC_SSC=y, > > but SND_ATMEL_SOC_SSC_PDC=m. Fix it bt reintroducing the default Kconfig. > > Defaults won't forbid the invalid configuration. Can you try following: Ah, no. This won't fix it - the dependency is the other way around: SOC_SSC should depend on _PDC / _DMA. > diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig > index f118c229ed82..461f023c5635 100644 > --- a/sound/soc/atmel/Kconfig > +++ b/sound/soc/atmel/Kconfig > @@ -12,10 +12,12 @@ if SND_ATMEL_SOC > config SND_ATMEL_SOC_PDC > tristate > depends on HAS_DMA > + select SND_ATMEL_SOC_SSC > > config SND_ATMEL_SOC_DMA > tristate > select SND_SOC_GENERIC_DMAENGINE_PCM > + select SND_ATMEL_SOC_SSC > > config SND_ATMEL_SOC_SSC > tristate > @@ -24,7 +26,6 @@ config SND_ATMEL_SOC_SSC_PDC > tristate "SoC PCM DAI support for AT91 SSC controller using PDC" > depends on ATMEL_SSC > select SND_ATMEL_SOC_PDC > - select SND_ATMEL_SOC_SSC > help > Say Y or M if you want to add support for Atmel SSC interface > in PDC mode configured using audio-graph-card in device-tree. > @@ -33,7 +34,6 @@ config SND_ATMEL_SOC_SSC_DMA > tristate "SoC PCM DAI support for AT91 SSC controller using DMA" > depends on ATMEL_SSC > select SND_ATMEL_SOC_DMA > - select SND_ATMEL_SOC_SSC > help > Say Y or M if you want to add support for Atmel SSC interface > in DMA mode configured using audio-graph-card in device-tree. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
