Re: [PATCH v2] ASoC: Intel: Skylake: prevent memory leak in snd_skl_parse_uuids

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>, Cezary Rojewski <cezary.rojewski@xxxxxxxxx>
Subject: Re: [PATCH v2] ASoC: Intel: Skylake: prevent memory leak in snd_skl_parse_uuids
From: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
Date: Fri, 27 Sep 2019 11:37:24 -0500
Cc: alsa-devel@xxxxxxxxxxxxxxxx, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, kjlu@xxxxxxx, Jie Yang <yang.jie@xxxxxxxxxxxxxxx>, Takashi Iwai <tiwai@xxxxxxxx>, Liam Girdwood <liam.r.girdwood@xxxxxxxxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, smccaman@xxxxxxx, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Navid Emamdoost <navid.emamdoost@xxxxxxxxx>, Enrico Weigelt <info@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, emamd001@xxxxxxx
In-reply-to: <20190927153304.GS32742@smile.fi.intel.com>
References: <20190925161922.22479-1-navid.emamdoost@gmail.com> <13f4bd40-dbaa-e24e-edca-4b4acff9d9c5@linux.intel.com> <20190927025526.GD22969@cs-dulles.cs.umn.edu> <dc68e0dc-9a8e-cc52-c560-3e86c783dbb3@linux.intel.com> <6966df25-e82c-1abe-6a0f-ff497dcda23b@intel.com> <20190927153304.GS32742@smile.fi.intel.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0

The problem with solution #1 is freeing orphaned pointer. It will work,
but it's simple is not okay from object life time prospective.


?? I don't get your point at all Andy.

Two allocations happens in a loop and if the second fails, you free thefirst and then jump to free everything allocated in the previousiterations. what am I missing?

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Follow-Ups:
- Re: [PATCH v2] ASoC: Intel: Skylake: prevent memory leak in snd_skl_parse_uuids
  - From: Andy Shevchenko

References:
- Re: [PATCH v2] ASoC: Intel: Skylake: prevent memory leak in snd_skl_parse_uuids
  - From: Pierre-Louis Bossart
- Re: [PATCH v2] ASoC: Intel: Skylake: prevent memory leak in snd_skl_parse_uuids
  - From: Pierre-Louis Bossart
- Re: [PATCH v2] ASoC: Intel: Skylake: prevent memory leak in snd_skl_parse_uuids
  - From: Cezary Rojewski
- Re: [PATCH v2] ASoC: Intel: Skylake: prevent memory leak in snd_skl_parse_uuids
  - From: Andy Shevchenko

Prev by Date: Re: [PATCH v5] dt-bindings: sound: Convert Samsung I2S controller to dt-schema
Next by Date: Re: [PATCH v2] ASoC: soc-pcm: Use different sequence for start/stop trigger
Previous by thread: Re: [PATCH v2] ASoC: Intel: Skylake: prevent memory leak in snd_skl_parse_uuids
Next by thread: Re: [PATCH v2] ASoC: Intel: Skylake: prevent memory leak in snd_skl_parse_uuids
Index(es):
- Date
- Thread

[Index of Archives] [ALSA User] [Linux Audio Users] [Pulse Audio] [Kernel Archive] [Asterisk PBX] [Photo Sharing] [Linux Sound] [Video 4 Linux] [Gimp] [Yosemite News]