Re: About soc_check_tplg_fes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 9/25/19 8:25 AM, Daniel Baluta wrote:
Hi all,

In function soc_check_tplg_fes (sound/soc/soc-core.c)
there is this code:

     for_each_card_prelinks(card, i, dai_link) {

         /* ignore this FE */
         if (dai_link->dynamic) {
             dai_link->ignore = true;
             continue;
         }
         dev_info(card->dev, "info: override FE DAI link %s\n",
             card->dai_link[i].name);

So, we ignore any FE DAI link but then the info message says the contrary.

Any idea?

Yes, there a couple of such BE/FE inversions in comments, likely copy/paste and typos. I just saw some earlier this week in the trigger error messages, e.g.

	err = dpcm_be_dai_trigger(fe, stream, SNDRV_PCM_TRIGGER_STOP);
	if (err < 0)
		dev_err(fe->dev,"ASoC: trigger FE failed %d\n", err);


We should really look for all comments with 'FE' or 'BE' and clean this up.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux