Re: DPCM: suspicious code in dpcm_prune_paths()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 10, 2019 at 11:20:17AM +0200, Guennadi Liakhovetski wrote:

> This code in dpcm_prune_paths() seems to have no effect:

> 		/* is there a valid CODEC DAI widget for this BE */
> 		for_each_rtd_codec_dai(dpcm->be, i, dai) {
> 			widget = dai_get_widget(dai, stream);
> 
> 			/* prune the BE if it's no longer in our active list */
> 			if (widget && widget_in_list(list, widget))
> 				continue;
> 		}

> Neither of the variables, that are modified in this loop are used outside 
> of it. Was the "continue" maybe meant to continue the encompassing loop?

Liam?

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux