On Tue, Sep 17, 2019 at 03:40:59PM +0800, shifu0704@xxxxxxxxxxxxxxx wrote: > > +reload: > > + /* hardware reset and reload */ > > + tas2770_load_config(tas2770); > Sometimes devices need to be reset to return to normal, and this setting is necessary. But why do we have systems where the device is being reset? Like I keep saying I'd just get a normal driver merged first, then go back and figure out what's going on with the reset support so it can be reviewed separately. > > +end: > > + return IRQ_HANDLED; > > +} > I see that the other drivers, the return values in irq_handler are IRQ_HANDLED. If they've actually handled an interrupt. There's some buggy drivers that do it unconditionally, they aren't a good reason to add more.
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
