Re: [PATCH 06/13] ASoC: soc-core: merge soc_free_pcm_runtime() and soc_rtd_free()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sridharan

Thank you for your review.


>     -static void soc_rtd_free(struct snd_soc_pcm_runtime *rtd)
>     -{
>     -       if (rtd->dev_registered) {
>     -               /* we don't need to call kfree() for rtd->dev */
> 
> Morimoto-san,
> 
> I think it is useful to keep this comment when you move soc_rtd_free() to  soc_free_pcm_runtime().

Yeah, indeed.
In my mind, the comment /* soc_release_rtd_dev */ was almost for it.
But, yes, Let's keep above comment too.
will fix in v2

>     +       if (rtd->dev)
>     +               device_unregister(rtd->dev); /* soc_release_rtd_dev */
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux