Hi Sridharan Thank you for your review. > -static void soc_rtd_free(struct snd_soc_pcm_runtime *rtd) > -{ > - if (rtd->dev_registered) { > - /* we don't need to call kfree() for rtd->dev */ > > Morimoto-san, > > I think it is useful to keep this comment when you move soc_rtd_free() to soc_free_pcm_runtime(). Yeah, indeed. In my mind, the comment /* soc_release_rtd_dev */ was almost for it. But, yes, Let's keep above comment too. will fix in v2 > + if (rtd->dev) > + device_unregister(rtd->dev); /* soc_release_rtd_dev */ _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel