Re: [PATCH] tas2770: add tas2770 smart PA dt bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Shi

One other thing

On 9/10/19 8:21 AM, Dan Murphy wrote:
Shi

On 9/6/19 2:06 AM, shifu0704@xxxxxxxxxxxxxxx wrote:
From: Frank Shi <shifu0704@xxxxxxxxxxxxxxx>

Subject should be

dt-bindings: ASoC: Add tas2770 smart PA dt bindings

Also Please add Rob Herring <robh+dt@xxxxxxxxxx> for review

add tas2770 smart PA dt bindings

Signed-off-by: Frank Shi <shifu0704@xxxxxxxxxxxxxxx>
---
  Documentation/devicetree/bindings/tas2770.txt | 38 +++++++++++++++++++++++++++
  1 file changed, 38 insertions(+)
  create mode 100644 Documentation/devicetree/bindings/tas2770.txt

diff --git a/Documentation/devicetree/bindings/tas2770.txt b/Documentation/devicetree/bindings/tas2770.txt
This binding belongs in Documentation/devicetree/bindings/sound
new file mode 100644
index 0000000..f70b310
--- /dev/null
+++ b/Documentation/devicetree/bindings/tas2770.txt
@@ -0,0 +1,38 @@
+Texas Instruments TAS2770 Smart PA
+
+The TAS2770 is a mono, digital input Class-D audio amplifier optimized for
+efficiently driving high peak power into small loudspeakers.
+Integrated speaker voltage and current sense provides for
+real time monitoring of loudspeaker behavior.
+
+Required properties:
+
+ - compatible:       - Should contain "ti,tas2770".
+ - reg:               - The i2c address. Should contain <0x4c>, <0x4d>,<0x4e>, or <0x4f>.
s/should/may
+ - #address-cells  - Should be <1>.
+ - #size-cells     - Should be <0>.
+ - ti,asi-format:  - Sets TDM RX capture edge. 0->Rising; 1->Falling.
+ - ti,left-slot:   - Sets TDM RX left time slots.
+ - ti,right-slot:  - Sets TDM RX right time slots.
+ - ti,imon-slot-no:- TDM TX current sense time slot.
+ - ti,vmon-slot-no:- TDM TX voltage sense time slot.
+
+Optional properties:
+
+ - reset-gpio:    Reset GPIO number of left device.
+ - irq-gpio:  IRQ GPIO number of left device.

You might want to use

- interrupt-parent: the phandle to the interrupt controller which provides
                    the interrupt.
- interrupts: interrupt specification for data-ready.

Instead of irq-gpio

+
+Examples:
+
+    tas2770@4c {
+                compatible = "ti,tas2770";
+                reg = <0x4c>;

Missing

#address-cells = <1>;

#size-cells = <0>;

+                reset-gpio = <&gpio15 1 GPIO_ACTIVE_LOW>;
+                irq-gpio = <&gpio16 1 GPIO_ACTIVE_LOW>;
+                ti,asi-format = <0>;
+                ti,left-slot = <0>;
+                ti,right-slot = <1>;
+                ti,imon-slot-no = <0>;
+                ti,vmon-slot-no = <2>;
+        };
+

Suggestion to provide the URL to the data sheet.

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux