Re: [PATCH v5 4/4] ASoC: codecs: add wsa881x amplifier support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




+static int wsa881x_ramp_pa_gain(struct snd_soc_component *comp,
+				int min_gain, int max_gain, int udelay)
+{
+	int val;
+
+	for (val = min_gain; max_gain <= val; val--) {
+		snd_soc_component_update_bits(comp, WSA881X_SPKR_DRV_GAIN,
+					      0xF0, val << 4);
+		/*
+		 * 1ms delay is needed for every step change in gain as per
+		 * HW requirement.
+		 */
+		usleep_range(udelay, udelay + 10);

nit-pick: it'd be nicer to have udelay explicitly set here instead of in the caller below for consistency with the comments.

+			wsa881x_ramp_pa_gain(comp, min_gain, max_gain, 1000);

But apart from that I didn't see anything blatantly wrong, so

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux