Re: [PATCH] ASoC: Intel: Baytrail: Fix implicit fallthrough warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2019-08-22 16:08, Pierre-Louis Bossart wrote:
On 8/22/19 7:01 AM, Cezary Rojewski wrote:
Separate _SUSPEND from _PAUSE_PUSH to ensure code is handled correctly
while fixing warning reported during compilation.

Fixes: b80d19c166c4 ("ASoC: Intel: Restore Baytrail ADSP streams only when ADSP was in reset")
Signed-off-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx>
---
  sound/soc/intel/baytrail/sst-baytrail-pcm.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/sound/soc/intel/baytrail/sst-baytrail-pcm.c b/sound/soc/intel/baytrail/sst-baytrail-pcm.c
index 9cbc982d46a9..eddb24ab8072 100644
--- a/sound/soc/intel/baytrail/sst-baytrail-pcm.c
+++ b/sound/soc/intel/baytrail/sst-baytrail-pcm.c
@@ -193,6 +193,8 @@ static int sst_byt_pcm_trigger(struct snd_pcm_substream *substream, int cmd)
          break;
      case SNDRV_PCM_TRIGGER_SUSPEND:
          pdata->restore_stream = false;
+        sst_byt_stream_pause(byt, pcm_data->stream);
+        break;

why not just a /* fallthrough */ statement?


Just a matter of taste. Sending v2 with update.

      case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
          sst_byt_stream_pause(byt, pcm_data->stream);
          break;


_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux