On Wed, Aug 14, 2019 at 1:51 PM Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> wrote: > > > > There seems to be an issue when suspending the ALC5650. I think the > > nondeterministic behavior I was seeing just had to do with whether or > > not the DSP had yet suspended. > > > > I reverted commit 0d2135ecadb0 ("ASoC: Intel: Work around to fix HW D3 > > potential crash issue") and things started working, including > > suspend/resume of the DSP. Any ideas for why this may be? I would like > > to resolve this so I can finish upstreaming the bdw-rt5650 machine > > driver. > > Copying Keyon in case he remembers the context. > > Reverting a 5yr-old commit with all sorts of clock/power-related fixes > looks brave, and it's not clear why this would work with the rt5677 and > not with 5650. No idea, I was just diffing the register writes looking for sources of discrepancy. The Chromium OS 3.14 kernel tree that Buddy uses doesn't have this patch, so I figured what's the worst that could happen? > > Are you using the latest upstream firmware btw? Or the one which shipped > with the initial device (which could be an issue if the protocol changed). The firmware I'm loading is: `FW info: type 01, - version: 00.00, build 77, source commit id: 876ac6906f31a43b6772b23c7c983ce9dcb18a1`. Hashes the same as the upstream binary. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel