On Wed, Aug 14, 2019 at 08:08:42AM +0200, codekipper@xxxxxxxxx wrote: > + if (i2s->variant->has_fmt_set_lrck_period) > + bclk_div = sun4i_i2s_get_bclk_div(i2s, clk_rate / rate, > + word_size, > + sun8i_i2s_clk_div, > + ARRAY_SIZE(sun8i_i2s_clk_div)); > + else > + bclk_div = sun4i_i2s_get_bclk_div(i2s, oversample_rate, > + word_size, > + sun4i_i2s_bclk_div, > + ARRAY_SIZE(sun4i_i2s_bclk_div)); Are we sure there'll never be any new variants which would make a switch statement for the variant work better?
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel