On 13-08-19, 20:58, Mark Brown wrote: > On Tue, Aug 13, 2019 at 02:38:53PM -0500, Pierre-Louis Bossart wrote: > > > Indeed. I don't have a full understanding of that part to be honest, nor why > > we need something SoundWire-specific. We already abused the set_tdm_slot API > > to store an HDaudio stream, now we have a rather confusing stream > > information for SoundWire and I have about 3 other 'stream' contexts in > > SOF... I am still doing basic cleanups but this has been on my radar for a > > while. > > There is something to be said for not abusing the TDM slot API if it can > make things clearer by using bus-idiomatic mechanisms, but it does mean > everything needs to know about each individual bus :/ . Here ASoC doesn't need to know about sdw bus. As Srini explained, this helps in the case for him to get the stream context and set the stream context from the machine driver. Nothing else is expected to be done from this API. We already do a set using snd_soc_dai_set_sdw_stream(). Here we add the snd_soc_dai_get_sdw_stream() to query Thanks -- ~Vinod _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
