On Fri, 09 Aug 2019 14:53:55 +0200, Takashi Iwai wrote: > > On Fri, 09 Aug 2019 13:01:00 +0200, > YueHaibing wrote: > > > > Building with SND_SOC_SOF_HDA_AUDIO_CODEC fails: > > > > sound/soc/sof/intel/hda-bus.c: In function sof_hda_bus_init: > > sound/soc/sof/intel/hda-bus.c:16:25: error: implicit declaration of function > > snd_soc_hdac_hda_get_ops; did you mean snd_soc_jack_add_gpiods? [-Werror=implicit-function-declaration] > > #define sof_hda_ext_ops snd_soc_hdac_hda_get_ops() > > > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > > Suggested-by: Takashi Iwai <tiwai@xxxxxxx> > > Fixes: d4ff1b3917a5 ('ASoC: SOF: Intel: Initialize hdaudio bus properly") > ^ > Use " consistently for both opening and closing quotes. > > > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> > > Reviewed-by: Takashi Iwai <tiwai@xxxxxxx> Actually I'm going to take this again on top of topic/hda-bus-ops-cleanup branch of my tree, so Mark, feel free to pull onto yours again. Sorry for the mess! Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel