On 2019-08-07 17:02, Pierre-Louis Bossart wrote:
From: Daniel Baluta <daniel.baluta@xxxxxxx>
So we are basically moving code from intel/byt.c to loader.c keeping in mind that mbox_offset is a per platform constant so we need to use newly introduced snd_sof_dsp_get_mailbox_offset / snd_sof_dsp_get_window_offset in order to get the correct mbox offset / window offset value.
You've already explained your goal. These details are unnecessary.
Also, bar is a per platform constant so we use snd_sof_dsp_get_bar_index instead of the hardcoded BYT_DSP_BAR. Signed-off-by: Daniel Baluta <daniel.baluta@xxxxxxx> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> --- sound/soc/sof/intel/byt.c | 164 +++++-------------------------------- sound/soc/sof/loader.c | 168 ++++++++++++++++++++++++++++++++++++++ sound/soc/sof/sof-priv.h | 2 + 3 files changed, 189 insertions(+), 145 deletions(-)
Hmm, even the commit message mentions two steps, not one. Splitting this commit into two - introduction of new generic functions and byt alignment towards the newly added approach - seems reasonable. Bdw & hda followups already make good examples.
Czarek _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
