Re: [PATCH 07/28] ASoC: soc-core: don't check widget for snd_soc_dapm_new_controls()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 05, 2019 at 09:35:58PM -0700, Ranjani Sridharan wrote:
> On Tue, 2019-08-06 at 10:28 +0900, Kuninori Morimoto wrote:

> > -	if (card->dapm_widgets)
> > -		snd_soc_dapm_new_controls(&card->dapm, card-
> > >dapm_widgets,
> > -					  card->num_dapm_widgets);
> > +	snd_soc_dapm_new_controls(&card->dapm, card->dapm_widgets,
> > +				  card->num_dapm_widgets);

> Should the return value be checked here?

Preexisting bug but yes.

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux