On Tue, Aug 06, 2019 at 11:46:28AM -0500, Pierre-Louis Bossart wrote:
> On 8/6/19 11:22 AM, Mark Brown wrote:
> > ...with this, the two in combination add protection against a double
> > free. Not 100% sure it's worth it but I queued the patch since I
> > couldn't strongly convince myself it's a bad idea.
> I was only referring to the first test, which will be duplicated. see below.
> The second part is just fine.
> {
> struct dentry *child, *parent;
>
> if (IS_ERR_OR_NULL(dentry))
> return;
Oh, I see it's got a NULL test in it. TBH I don't think it hurts to
check in the caller, it avoids someone having to check to make sure that
the NULL check is in the function.
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
