Re: [PATCH v2] ALSA: i2c: ak4xxx-adda: Fix a possible null pointer dereference in build_adc_controls()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 26 Jul 2019 04:14:42 +0200,
Jia-Ju Bai wrote:
> 
> In build_adc_controls(), there is an if statement on line 773 to check
> whether ak->adc_info is NULL:
>     if (! ak->adc_info ||
>         ! ak->adc_info[mixer_ch].switch_name)
> 
> When ak->adc_info is NULL, it is used on line 792:
>     knew.name = ak->adc_info[mixer_ch].selector_name;
> 
> Thus, a possible null-pointer dereference may occur.
> 
> To fix this bug, referring to lines 773 and 774, ak->adc_info
> and ak->adc_info[mixer_ch].selector_name are checked before being used.
> 
> This bug is found by a static analysis tool STCheck written by us.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@xxxxxxxxx>

Applied, thanks.


Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux