On Thu, Jul 25, 2019 at 01:47:33PM +0100, Mark Brown wrote:
> On Thu, Jul 25, 2019 at 01:31:51PM +0100, Charles Keepax wrote:
>
> > select SND_SOC_CS47L24 if MFD_CS47L24
> > + select SND_SOC_CS47L15 if MFD_CS47L15
> > select SND_SOC_CS47L35 if MFD_CS47L35
>
> The Makefile and Kconfig sorting is a bit off. Please send a followup
> fixing this.
>
Can do.
> > +static irqreturn_t cs47l15_adsp2_irq(int irq, void *data)
> > +{
> > + struct cs47l15 *cs47l15 = data;
> > + struct madera_priv *priv = &cs47l15->core;
> > + struct madera *madera = priv->madera;
> > + int ret;
> > +
> > + ret = wm_adsp_compr_handle_irq(&priv->adsp[0]);
> > + if (ret == -ENODEV) {
> > + dev_err(madera->dev, "Spurious compressed data IRQ\n");
> > + return IRQ_NONE;
> > + }
> > +
> > + return IRQ_HANDLED;
> > +}
> > +
> > +static irqreturn_t cs47l15_dsp_bus_error(int irq, void *data)
> > +{
> > + struct wm_adsp *dsp = (struct wm_adsp *)data;
> > +
> > + return wm_adsp2_bus_error(dsp);
> > +}
>
> Noticeable difference in pattern between these two interrupt helpers
> (and makes me wonder why we need the wrappers at all).
Yeah there doesn't seem to be any need for the wrappers.
I will respin the series and fixup these two issues.
Thanks,
Charles
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
