On Mon, Jul 22, 2019 at 08:57:44AM -0500, Wenwen Wang wrote: > From: Wenwen Wang <wenwen@xxxxxxxxxx> > > In snd_soc_dapm_new_control_unlocked(), a kernel buffer is allocated in > dapm_cnew_widget() to hold the new dapm widget. Then, different actions are > taken according to the id of the widget, i.e., 'w->id'. If any failure > occurs during this process, snd_soc_dapm_new_control_unlocked() should be > terminated by going to the 'request_failed' label. However, the allocated > kernel buffer is not freed on this code path, leading to a memory leak bug. > > To fix the above issue, free the buffer before returning from > snd_soc_dapm_new_control_unlocked() through the 'request_failed' label. > > Signed-off-by: Wenwen Wang <wenwen@xxxxxxxxxx> > --- Reviewed-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx> Thanks, Charles _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
