On Fri, 19 Jul 2019 20:20:58 +0200, Pierre-Louis Bossart wrote: > > Thanks for the quick review Takashi, much appreciated. > > On 7/19/19 1:09 PM, Takashi Iwai wrote: > > On Fri, 19 Jul 2019 19:06:07 +0200, > > Pierre-Louis Bossart wrote: > >> > >> Each assignment is final so there's no point in doing an OR. > >> > >> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> > > > > Please fold into the patch 2. There is no reason to split. > > Sure. I just wanted to keep this separate since patch2 is mostly about > moving code. No problem to squash it. FWIW, if it's really a code movement, it'd make sense to split, yes. But in this case, the patch 2 simply puts a new code. The actual code "move" happens in the patch 5. thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
