Hello Fabio, Thank you for your feedback! I've prepared and sent a fixed patchset v4. -- R&D Engineer Oleksandr Suvorov Toradex AG ________________________________________ From: Fabio Estevam <festevam@xxxxxxxxx> Sent: Monday, July 15, 2019 10:06:57 PM To: Oleksandr Suvorov Cc: linux-kernel@xxxxxxxxxxxxxxx; alsa-devel@xxxxxxxxxxxxxxxx; Marcel Ziswiler; Igor Opaniuk; Jaroslav Kysela; Mark Brown; Takashi Iwai; Liam Girdwood Subject: Re: [PATCH v3 0/6] VAG power control improvement for sgtl5000 codec Hi Oleksandr, Your series looks good, thanks. I only have one suggestion. On Fri, Jul 12, 2019 at 11:56 AM Oleksandr Suvorov <oleksandr.suvorov@xxxxxxxxxxx> wrote: > > > VAG power control is improved to fit the manual [1]. This patchset fixes as > minimum one bug: if customer muxes Headphone to Line-In right after boot, > the VAG power remains off that leads to poor sound quality from line-in. > > I.e. after boot: > - Connect sound source to Line-In jack; > - Connect headphone to HP jack; > - Run following commands: > $ amixer set 'Headphone' 80% > $ amixer set 'Headphone Mux' LINE_IN Could you please make the bug fix patch to appear as the first one in the series with a Fixes tag and Cc stable? This way the bug fix can be applied to the linux stable tree. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
