Re: [PATCH] ASoC: fsl_sai: mark regmap as fast_io

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Mittwoch, den 17.07.2019, 12:06 +0100 schrieb Mark Brown:
> On Wed, Jul 17, 2019 at 12:51:56PM +0200, Lucas Stach wrote:
> 
> > The regmap is only ever used to access MMIO registers, so it's fair
> > to say that register access is fast.
> 
> Are you sure there's no caches that try to do allocations at
> runtime?  The main thing fast_io does is change the locking to
> spinlocks which means we shouldn't do any allocations under lock,
> such as when updating the cache.

This driver is using REGCACHE_FLAT, which does its sole allocation on
init and none at reg access time AFAICS. So this should be okay.

Regards,
Lucas
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux