On Mon, 08 Jul 2019 13:04:48 +0200, Adam Miartus wrote: > > From: Andreas Pape <apape@xxxxxxxxxxxxxx> > > Signed-off-by: Andreas Pape <apape@xxxxxxxxxxxxxx> > Signed-off-by: Adam Miartus <amiartus@xxxxxxxxxxxxxx> No description isn't good at all. There must be something you can explain in details here. About the changes: > +#define PCM_UNSUPPORTED_ERR (-ENOSYS) > +void snd_pcm_unsupported_dump(snd_pcm_t *pcm, snd_output_t *out) > +{ > + snd_output_printf(out, "unsupported\n"); > +} IMO, we don't need to show anything if it's dummy. And, maybe it's more straightforward to let the PCM core allow NULL ops? thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel