Re: [PATCH v2 27/27] sound: ppc: remove unneeded memset after dma_alloc_coherent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





Le 28/06/2019 à 04:50, Fuqian Huang a écrit :
In commit af7ddd8a627c
("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
dma_alloc_coherent has already zeroed the memory.
So memset is not needed.

You are refering to a merge commit, is that correct ?

I can't see anything related in that commit, can you please pinpoint it ?

As far as I can see, on powerpc the memory has always been zeroized (since 2005 at least).

Christophe


Signed-off-by: Fuqian Huang <huangfq.daxian@xxxxxxxxx>
---
  sound/ppc/pmac.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/sound/ppc/pmac.c b/sound/ppc/pmac.c
index 1b11e53f6a62..1ab12f4f8631 100644
--- a/sound/ppc/pmac.c
+++ b/sound/ppc/pmac.c
@@ -56,7 +56,6 @@ static int snd_pmac_dbdma_alloc(struct snd_pmac *chip, struct pmac_dbdma *rec, i
  	if (rec->space == NULL)
  		return -ENOMEM;
  	rec->size = size;
-	memset(rec->space, 0, rsize);
  	rec->cmds = (void __iomem *)DBDMA_ALIGN(rec->space);
  	rec->addr = rec->dma_base + (unsigned long)((char *)rec->cmds - (char *)rec->space);
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux