Re: [PATCH 01/23] ASoC: atmel: atmel-pcm:dma.c: use devm_snd_dmaengine_pcm_register()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Codrin

Thank you for your feedback

> >> From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> >>
> >> We have devm_xxx version of snd_dmaengine_pcm_register,
> >> let's use it.
> >>
> >> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> >> ---
(snip)
> >>   void atmel_pcm_dma_platform_unregister(struct device *dev)
> >>   {
> >> -	snd_dmaengine_pcm_unregister(dev);
> >>   }
> >>   EXPORT_SYMBOL(atmel_pcm_dma_platform_unregister);
> >>   
> > 
> > Do we need to keep empty function?
> 
> Most probably not... Kuninori, let me know if you want me to remove 
> atmel_pcm_dma_platform_unregister() from everywhere.

I'm asking it to Mark now.
pattern1 is I will post v2 which cares empty function.
pattern2 is I will post "remove empty function" patch set.

Anyway, thank you for your help !!

Thank you for your help !!
Best regards
---
Kuninori Morimoto
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux