On 6/18/19 2:23 AM, Bard liao wrote:
From: Xun Zhang <xun2.zhang@xxxxxxxxx> The sof-rt5682 machine driver currently uses BCLK on BYT/Minnowboard platform. The MCLK signal is available since the Turbot revision, so enable MCLK on BYT/Minnowboard Turbot platform.
The commit message is not wrong but for more context the MCLK is enabled on all known BYT/CHT platforms except early MinnowBoards and Up where the MCLK is not available on the low-speed/HAT connector.
Signed-off-by: Xun Zhang <xun2.zhang@xxxxxxxxx> Signed-off-by: Bard liao <yung-chuan.liao@xxxxxxxxxxxxxxx>
if (sof_rt5682_quirk & SOF_RT5682_MCLK_EN) { + if (sof_rt5682_quirk & SOF_RT5682_MCLK_BYTCHT_EN) { + ret = clk_prepare_enable(ctx->mclk); + if (ret < 0) { + dev_err(rtd->dev, + "could not configure MCLK state"); + return ret; + } + }
Note that we could technically fallback to using the BCLK only in the error case but it's an unlikely scenario which we've never seen, so
Patch 1 and 2 Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel