> Which platforms is this needed for? IIRC this machine driver is shared with SOF-based solutions - which typically sets DMIC configs with topology - and I'd like to make sure there's no impact. Hi Pierre, this is for APL platform. -----Original Message----- From: Pierre-Louis Bossart [mailto:pierre-louis.bossart@xxxxxxxxxxxxxxx] Sent: Tuesday, June 18, 2019 2:56 PM To: Chiang, Mac <mac.chiang@xxxxxxxxx>; alsa-devel@xxxxxxxxxxxxxxxx Cc: N, Harshapriya <harshapriya.n@xxxxxxxxx>; broonie@xxxxxxxxxx; Zhi, Yong <yong.zhi@xxxxxxxxx> Subject: Re: [PATCH] ASoC: Intel: boards: add dmic format constraint On 6/18/19 7:48 AM, mac.chiang@xxxxxxxxx wrote: > From: Mac Chiang <mac.chiang@xxxxxxxxx> > > platform dmic recording fixup 16bits Which platforms is this needed for? IIRC this machine driver is shared with SOF-based solutions - which typically sets DMIC configs with topology - and I'd like to make sure there's no impact. Thanks! > > Signed-off-by: Mac Chiang <mac.chiang@xxxxxxxxx> > --- > sound/soc/intel/boards/bxt_da7219_max98357a.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/sound/soc/intel/boards/bxt_da7219_max98357a.c > b/sound/soc/intel/boards/bxt_da7219_max98357a.c > index 5cadb7f..ac06408 100644 > --- a/sound/soc/intel/boards/bxt_da7219_max98357a.c > +++ b/sound/soc/intel/boards/bxt_da7219_max98357a.c > @@ -330,6 +330,9 @@ static int broxton_dmic_startup(struct snd_pcm_substream *substream) > snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNELS, > &constraints_channels_quad); > > + runtime->hw.formats = SNDRV_PCM_FMTBIT_S16_LE; > + snd_pcm_hw_constraint_msbits(runtime, 0, 16, 16); > + > return snd_pcm_hw_constraint_list(substream->runtime, 0, > SNDRV_PCM_HW_PARAM_RATE, &constraints_rates); > } > _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
