Hi Jiada
> From: Nilkanth Ahirrao <anilkanth@xxxxxxxxxxxxxx>
>
> commit 7e4f3419ebfe ("ASoC: rsnd: add .get_id/.get_id_sub")
> introduces rsnd_ctu_id which calcualates and gives
> the main Device id of the CTU by dividing the id by 4.
> rsnd_mod_id uses this interface to get the CTU main
> Device id. But this commit forgets to revert the main
> Device id calcution previously done in rsnd_ctu_probe_
> which also divides the id by 4. This path corrects the
> same to get the correct main Device id.
>
> The issue is observered when rsnd_ctu_probe_ is done for CTU1
>
> Fixes: 7e4f3419ebfe ("ASoC: rsnd: add .get_id/.get_id_sub")
>
> Signed-off-by: Nilkanth Ahirrao <anilkanth@xxxxxxxxxxxxxx>
> Signed-off-by: Suresh Udipi <sudipi@xxxxxxxxxxxxxx>
> Signed-off-by: Jiada Wang <jiada_wang@xxxxxxxxxx>
> ---
Thanks !!
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
But, I guess commit ID is this for upstream ?
c16015f36cc128244c910152663de45c3b99f551
("ASoC: rsnd: add .get_id/.get_id_sub")
> sound/soc/sh/rcar/ctu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/sh/rcar/ctu.c b/sound/soc/sh/rcar/ctu.c
> index 8cb06dab234e..7647b3d4c0ba 100644
> --- a/sound/soc/sh/rcar/ctu.c
> +++ b/sound/soc/sh/rcar/ctu.c
> @@ -108,7 +108,7 @@ static int rsnd_ctu_probe_(struct rsnd_mod *mod,
> struct rsnd_dai_stream *io,
> struct rsnd_priv *priv)
> {
> - return rsnd_cmd_attach(io, rsnd_mod_id(mod) / 4);
> + return rsnd_cmd_attach(io, rsnd_mod_id(mod));
> }
>
> static void rsnd_ctu_value_init(struct rsnd_dai_stream *io,
> --
> 2.19.2
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
