On Fri, Jun 14, 2019 at 04:34:05PM +0100, Mark Brown wrote: > On Fri, Jun 14, 2019 at 11:47:56AM +0200, Greg Kroah-Hartman wrote: > > > Note, the soc-pcm "state" file has now moved to a subdirectory, as it is > > only a good idea to save the dentries for debugfs directories, not > > individual files, as the individual file debugfs functions are changing > > to not return a dentry. > > It'd be better to split this out into a separate change for ease of > review. > > > - d = debugfs_create_file(w->name, 0444, > > - dapm->debugfs_dapm, w, > > - &dapm_widget_power_fops); > > - if (!d) > > - dev_warn(w->dapm->dev, > > - "ASoC: Failed to create %s debugfs file\n", > > - w->name); > > + debugfs_create_file(w->name, 0444, dapm->debugfs_dapm, w, > > + &dapm_widget_power_fops); > > The majority of this is removing error prints rather than code that > actively does something different. If this was like kmalloc() where the > API is itself reported errors then this wouldn't be an issue but unless > I'm missing something debugfs fails silently so this means that if > something goes wrong it's going to be harder for the user to figure out > where the debugfs files they wanted to check went to. I'm guessing you > don't want to add error prints in debugfs itself so I'd rather they > stayed here. > > Yes, the error check is looking for NULL not an error pointer - it was > correct when written but I see that the debugfs API changed earlier this > year to return error pointers so we ought to fix that up. No, the long-term goal is for debugfs_create_file() to just return void. I have already done enough cleanups in my local tree to do that already for many of the helper functions. No one should care one bit if a debugfs file succeeds or not, no logic should ever change, nor should it matter. debugfs is for debugging kernel code, not for anything that anyone should ever rely on. So yes, this patch does remove a bunch of error messages (that as you point out can never be triggered), but the main goal here is to not check the return value of the function at all, which is what this patch does. thanks, greg k-h _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
