Hi Rojewski Cc Pierre-Louis Thank you for your review, explanation, feedback. > > Hmm, guess reviewing 001 proved redundant after all. Unless I got it wrong, you are removing code implemented in that very patch (the 001). > > Not quite. There was already code to convert codecs and platforms to > the new representation but the cpu part was missing. The first patch > only deals with cpu dais. The last patch removes all the conversions > for codec/platform/cpu and uses the new representation across the > board, so there's more code removed in the last patch than added in > the first. > > > Any chance for eliminating ping-pong effect and doing the "right" changes from the get-go? Especially the renames are confusing here (s/cleanup_platform/cleanup_legacy/) if you intend to remove them soon after. > > Using a ping-pong analogy for a 146-patch series is pushing it. It's > first make then break to avoid bisect issues. And the names match what > is used in the existing code. maybe the naming isn't to your liking > but it's what has been used for a while. > > Note that the last patch is going to break all the non-upstream > machine drivers so you will have quite a bit of work to do on your own > when you rebase. This patch-set moves from "legacy style" to "modern style", [001] added glue code, and [146] removed "legacy style". I believe this is needed to support more complex multiple connection device, like multi-CPU / multi-Platform, etc, etc... As Pierre-Louis said, unfortunately last patch removes "legacy style" from ALSA SoC. I'm sorry to bother you, but, I / upstream can't care about out-of-tree code, unfortunately... Thank you for your help !! Best regards --- Kuninori Morimoto _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
