Re: [PATCH] ASoC: core: move DAI pre-links initiation to snd_soc_instantiate_card

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 4, 2019 at 1:10 AM Curtis Malainey <cujomalainey@xxxxxxxxxx> wrote:
>
> > >  probe_end:
> > > -       if (ret < 0)
> > > +       if (ret < 0 && ret != -EPROBE_DEFER)
> > >                 soc_cleanup_card_resources(card);
> > Should not call soc_cleanup_card_resources() if soc_init_dai_link()
> > returns fail.  Some context has not initialized yet in the case.
> Why not? You need to clean up the platform naming if links fails which
> will causes a use-after-free bug if you don't clean it up.
Some context may have not initialized if soc_init_dai_link() returns
fail.  See v2 https://patchwork.kernel.org/patch/10974149/ if it would
help.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux