Re: [RFC PATCH 5/6] ALSA / hda: stop probe if DMICS are detected on Skylake+ platforms

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 24 May 2019 01:39:50 +0200,
Pierre-Louis Bossart wrote:
> 
> The legacy HD-Audio driver cannot handle Skylake+ platforms with
> digital microphones. For those platforms, the SOF driver needs to be
> used.
> 
> Use the common intel-nhlt module to stop the probe when the DSP is
> enabled and DMICs are exposed in the NHTL tables.
> 
> Note: This assumes that the BIOS information is correct, and
> additional testing is required to see on which platforms the detection
> is a false positive.
> 
> FIXME: I need to find what is the mirror of azx_create() to free all
> the resources on exit.

azx_free() does the whole, so just goto out_free should suffice.

> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
> ---
>  sound/pci/hda/Kconfig     |  1 +
>  sound/pci/hda/hda_intel.c | 30 ++++++++++++++++++++++++++++++
>  2 files changed, 31 insertions(+)
> 
> diff --git a/sound/pci/hda/Kconfig b/sound/pci/hda/Kconfig
> index 4235907b7858..7b560c557b07 100644
> --- a/sound/pci/hda/Kconfig
> +++ b/sound/pci/hda/Kconfig
> @@ -11,6 +11,7 @@ config SND_HDA_INTEL
>  	tristate "HD Audio PCI"
>  	depends on SND_PCI
>  	select SND_HDA
> +	select SND_SOC_INTEL_NHLT

Better to select conditionally depending on ACPI

	select SND_SOC_INTEL_NHLT if ACPI


thanks,

Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux